macro/run_tracking_scan.py (2)

155-156: Minor duplication: gun_area_m2 computed in two places.

The gun area calculation 200 * 300 * 1e-4 appears at lines 156 and 284. Consider extracting it to a constant near the top of the file.

♻️ Extract constant

+# Gun area from benchmark defaults: Dx=200cm, Dy=300cm → m²
+GUN_AREA_M2 = 200 * 300 * 1e-4

 # ... in the scan loop:
-    gun_area_m2 = 200 * 300 * 1e-4
     all_results.append(
         {
             ...
-            "density_per_m2": round(n_tracks / gun_area_m2, 4),
+            "density_per_m2": round(n_tracks / GUN_AREA_M2, 4),

 # ... in matplotlib section:
-    gun_area_m2 = 200 * 300 * 1e-4  # Dx=200, Dy=300 cm
+    # GUN_AREA_M2 already defined at module level

Also applies to: 284-284

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@macro/run_tracking_scan.py` around lines 155 - 156, The calculation for
gun_area_m2 is duplicated; extract the value into a single constant (e.g.,
GUN_AREA_M2) defined near the top of the module and replace both occurrences of
the literal expression (200 * 300 * 1e-4) with that constant, updating uses of
gun_area_m2 in the functions/blocks that reference it so they read from
GUN_AREA_M2 and removing the duplicate local computation.

---

152-166: Consider adding error handling for JSON loading.

If the benchmark subprocess fails after creating but before completing the JSON file, json.load will raise an exception. While unlikely, adding a try-except would make the scan more robust.

♻️ Optional defensive check

-    with open(json_path) as f:
-        metrics = json.load(f)
+    try:
+        with open(json_path) as f:
+            metrics = json.load(f)
+    except (json.JSONDecodeError, KeyError) as e:
+        print(f"WARNING: Could not parse metrics from {json_path}: {e}")
+        continue

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@macro/run_tracking_scan.py` around lines 152 - 166, The json.load call
reading json_path can raise exceptions if the subprocess wrote an incomplete or
missing file; wrap the load in a try/except that catches FileNotFoundError,
json.JSONDecodeError (or json.decoder.JSONDecodeError) and any other Exception,
log a clear warning including json_path and the exception, and either skip
appending this result (or set metrics = {"tracking_benchmark": {}} / a safe
default) so that the subsequent all_results.append using
metrics["tracking_benchmark"] cannot crash; update the block around json.load,
json_path, metrics and the all_results.append to use the safe metrics value or
early-continue on error.

macro/run_simScript.py (1)

524-527: Consider validating particle type when --mixCharges is enabled.

The charge mixing logic assumes the particle has a valid antiparticle with PDG code -abs(pID). This works for charged particles like muons (±13) but would produce invalid PDG codes for neutral particles (e.g., photon 22 → -22 is undefined).

Consider adding a validation check or at least documenting that --mixCharges is only valid for charged particles.

♻️ Optional validation

 if options.command == "PG":
+    if options.mixCharges and options.nTracks > 1:
+        # Verify particle has a valid antiparticle (charged particle)
+        PDG = ROOT.TDatabasePDG.Instance()
+        particle = PDG.GetParticle(abs(options.pID))
+        if particle is None or particle.Charge() == 0:
+            print(f"WARNING: --mixCharges requested but pID={options.pID} is not a charged particle")
     if options.mixCharges and options.nTracks > 1:
         pids = [(abs(options.pID), options.nTracks // 2), (-abs(options.pID), (options.nTracks + 1) // 2)]

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@macro/run_simScript.py` around lines 524 - 527, When options.mixCharges is
true, validate that the chosen particle is actually charged before constructing
pids: check options.pID and ensure abs(options.pID) is not a known neutral PDG
(e.g., 22, 111, 130, 2112) or, if a particle lookup API exists in the codebase,
use it to confirm the particle has an antiparticle; if the check fails,
raise/exit with a clear error or disable mixCharges. Update the branch that sets
pids (references: options.mixCharges, options.pID, pids, options.nTracks) to
perform this validation first and only produce the two-charge split when the
particle is validated as charged.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes